Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support building with GHC 9.6 #1572

Merged
merged 4 commits into from
Sep 2, 2023
Merged

Support building with GHC 9.6 #1572

merged 4 commits into from
Sep 2, 2023

Commits on Aug 31, 2023

  1. Whitespace only

    @RyanGlScott
    RyanGlScott committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    22ab026 View commit details
    Browse the repository at this point in the history

  2. Support building with GHC 9.6 

    This contains a varity of changes needed to make `cryptol` compile with GHC
9.6:

* `mtl-2.3.1` (bundled with GHC 9.6) no longer re-exports `Control.Monad` or
  related modules from the various `mtl` modules. I now use explicit imports
  from `mtl` modules to ensure that the necessary identifiers are always in
  scope, regardless of whether we are using `mtl-2.3.*` or an older `mtl`
  version.
* `directory-1.3.8.0` (bundled with GHC 9.6) no longer marks its modules as
  `Safe`, so `Cryptol.TypeCheck.Solver.SMT` (a module explicitly marked as
  `Safe`) no longer compiles due to its `System.Directory` import. I have
  changed `Cryptol.TypeCheck.Solver.SMT` to be `Trustworthy` instead to avoid
  this.
* I have raised the upper version bounds on libraries such as `base` and `aeson`
  to allow a GHC 9.6–compatible build plan.
* I have bumped the `argo` submodule to bring in the changes from
  GaloisInc/argo#200, which allows `argo` to build with GHC 9.6.
    @RyanGlScott
    RyanGlScott committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    a41aa84 View commit details
    Browse the repository at this point in the history

  3. CI: Always save cache, even on failure

    @RyanGlScott
    RyanGlScott committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    a5b69e8 View commit details
    Browse the repository at this point in the history

  4. CI: Test GHC 9.6.2 and 9.4.7, drop GHC 8.10.7

    @RyanGlScott
    RyanGlScott committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    55fb062 View commit details
    Browse the repository at this point in the history