This repository has been archived by the owner on Jun 9, 2021. It is now read-only.
Reimplement saw-core error with userError instead of panic.
#61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a quick fix for #59.
robdockins
approved these changes
Jul 29, 2020
brianhuffman
pushed a commit
to GaloisInc/saw-script
that referenced
this pull request
Jul 29, 2020
…w4`. PR GaloisInc/cryptol#774 changed cryptol's defaulting rules in such a way that some indexing operators in `test_w4` are assigned different types. PR GaloisInc/saw-core#61 was then necessary to avoid a panic; also the out-of-bounds indexing tests have changed from expected proof success to expected proof failure.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix for #59.
Instead of
panic, we now throw an asynchronous exception of typeEvalErrorusing functionuserErrorfrom moduleVerifier.SAW.Prim. This is not the perfect solution (throwIOwould be better) but it is definitely better thanpanic, and calling the saw-coreerrorfunction no longer will causesawto exit.