Skip to content

Commit

Permalink
write_aig: Normalize symmetry in multiplication
Browse files Browse the repository at this point in the history
This bumps the `aig` submodule to bring in the changes from GaloisInc/aig#14,
which changes how `aig` performs multiplication to swap the order of arguments
if the second argument is a constant. This has two benefits:

* This ensures that `write_aig` will produce the same networks for `X * C` and
  `C * X`, where `C` is a constant and `X` is a variable.
* The algorithm that `mul` uses to compute multiplication is biased in its order
  of arguments, and having the first argument be a constant tends to produce
  networks that ABC has an easier time verifying. (The FFS example under
  `doc/tutorial/code/ffs.c` is a notable example of this.)

I have added a test case to check to see if the test case from #1828 now
produces identical AIGs regardless of the order of arguments.

Fixes #1828.
  • Loading branch information
RyanGlScott committed Mar 9, 2023
1 parent 8eaf10e commit 66875f5
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 1 deletion.
2 changes: 1 addition & 1 deletion deps/aig
Submodule aig updated 2 files
+1 −1 aig.cabal
+30 −1 src/Data/AIG/Operations.hs
2 changes: 2 additions & 0 deletions intTests/test1828/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
left.aig
right.aig
2 changes: 2 additions & 0 deletions intTests/test1828/test.saw
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
write_aig "left.aig" {{ \x -> x * 0x12345678 }};
write_aig "right.aig" {{ \x -> 0x12345678 * x }};
9 changes: 9 additions & 0 deletions intTests/test1828/test.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
set -e

# This test case uses `write_aiger` to produce AIG files for two nearly
# identical functions, where the only difference is the order of arguments (one
# symbolic and one concrete) in a bitvector multiplication. If the `aig` library
# does its job correctly, these should produce identical AIG files, so check
# this using `diff`.
$SAW test.saw
diff -ru left.aig right.aig

0 comments on commit 66875f5

Please sign in to comment.