Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates flowing from cryptol PRs #1048 and #1136 #1191

Merged
merged 4 commits into from
May 21, 2021
Merged

Updates flowing from cryptol PRs #1048 and #1136 #1191

merged 4 commits into from
May 21, 2021

Conversation

robdockins
Copy link
Contributor

No description provided.

@brianhuffman brianhuffman added the PR: submodule bump Pull requests that include a submodule bump label Apr 26, 2021
@brianhuffman
Copy link
Contributor

brianhuffman commented Apr 26, 2021 •
edited
Loading

Might want to update the commit message so that github references the cross-repository PR numbers correctly: GaloisInc/cryptol#1048 and GaloisInc/cryptol#1136.

Also note that GaloisInc/cryptol#1128 "persist-solver2" precedes those two PRs and also contains breaking changes for saw-script (and saw-remote-api) so we'll have to address that one first.

@robdockins robdockins mentioned this pull request Apr 27, 2021
Closed
@robdockins
Copy link
Contributor Author

Whoops. Yeah, I'll fix those references via a rebase.

@robdockins
Copy link
Contributor Author

This PR should land after #1267 and will probably need some updating once it does.

@robdockins robdockins marked this pull request as ready for review May 18, 2021 18:40
@robdockins robdockins requested a review from brianhuffman May 18, 2021 18:40
@robdockins robdockins added PR: keep updated Magic flag for pull requests to ask Mergify to merge head into the PR branch for you PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run labels May 19, 2021
@robdockins
Copy link
Contributor Author

@brianhuffman, any chance you can take a look at this soon? I think it makes sense to merge this next.

brianhuffman
brianhuffman approved these changes May 21, 2021
View reviewed changes
Copy link
Contributor

@brianhuffman brianhuffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mergify mergify bot merged commit 1a6dd61 into master May 21, 2021
@mergify mergify bot deleted the cryptol/PR1136 branch May 21, 2021 02:02
@brianhuffman brianhuffman mentioned this pull request Jul 13, 2021
Closed
@RyanGlScott RyanGlScott mentioned this pull request Jul 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianhuffman brianhuffman brianhuffman approved these changes

Assignees
No one assigned
Labels
PR: keep updated Magic flag for pull requests to ask Mergify to merge head into the PR branch for you PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run PR: submodule bump Pull requests that include a submodule bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robdockins @brianhuffman