CVC4: Add patches to ease building on AArch64 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the patches from #50, which will make it easier to build CVC4 on AArch64 (and especially AArch64 Linux) in the future: * `cvc4-antlr-check-aarch64.patch` This updates the very old `config.guess` and `config.sub` scripts that ANTLR uses (dating back to 2009) to more recent ones that are aware of AArch64 Linux and Darwin. Doing so fixes a spurious warning about building for 32-bit on AArch64 Darwin (thereby fixing #53) and unbreaks the AArch64 Linux build. Also, ANTLR's `configure` script will pass x86-specific flags such as `-m64` by default, which aren't supported by `gcc` on other architectures (e.g., AArch64). We can prevent this by passing `--disable-abiflags` to `configure` on these architectures. * `cvc4-antlr-pointer-to-integer-cast.patch`: Fix an implicit pointer-to-integer cast that causes x86-64 `gcc` to warn, but causes AArch64 `gcc` to fail with a full-blown error.
RyanGlScott
force-pushed
the
aarch64-patches
branch
2 times, most recently
from
2b227e3 to
7df8cbd
Compare
mccleeary-galois
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds three patches from #50, which will make it easier to build CVC4 on AArch64 (and especially AArch64 Linux) in the future:
cvc4-antlr-update-config-guess.patch: This updates the very oldconfig.guessscript that ANTLR uses (dating back to 2009) to a more recent one that is aware of AArch64 Linux and Darwin. Doing so fixes a spurious warning about building for 32-bit on AArch64 Darwin (thereby fixing Suspicious warning when building CVC4 onmacos-14#53) and unbreaks the AArch64 Linux build when combined with the next patch...cvc4-antlr-check-aarch64.patch: By default, ANTLR'sconfigurescript will pass x86-specific flags such as-m64, which aren't supported bygccon other architectures (e.g., AArch64). We can prevent this by passing--disable-abiflagstoconfigureon these architectures.cvc4-antlr-pointer-to-integer-cast.patch: Fix an implicit pointer-to-integer cast that causes x86-64gccto warn, but causes AArch64gccto fail with a full-blown error.