test(core): move create-account integration tests (#3817)

* test(core): move update-language tests to bats and new integration

* test(core): move create-account tests to new integration

* test(core): remove redundant 'createAccount' helper

bats/core/api/user.bats

@@ -0,0 +1,26 @@
+load "../../helpers/user.bash"
+
+setup_file() {
+  create_user 'alice'
+}
+
+@test "account: updates language" {
+  local new_language="de"
+
+  exec_graphql 'alice' 'user-details'
+  language="$(graphql_output '.data.me.language')"
+  [[ "$language" == "" ]] || exit 1
+
+  local variables=$(
+    jq -n \
+    --arg language "$new_language" \
+    '{input: {language: $language}}'
+  )
+  exec_graphql 'alice' 'user-update-language' "$variables"
+  changed_language="$(graphql_output '.data.userUpdateLanguage.user.language')"
+  [[ "$changed_language" == "$new_language" ]] || exit 1
+
+  exec_graphql 'alice' 'user-details'
+  language="$(graphql_output '.data.me.language')"
+  [[ "$language" == "$new_language" ]] || exit 1
+}

bats/gql/user-details.gql

@@ -0,0 +1,6 @@
+query userDetails {
+  me {
+    id
+    language
+  }
+}

bats/gql/user-update-language.gql

@@ -0,0 +1,11 @@
+mutation userUpdateLanguage($input: UserUpdateLanguageInput!) {
+  userUpdateLanguage(input: $input) {
+    user {
+      language
+    }
+    errors {
+      code
+      message
+    }
+  }
+}

core/api/src/app/accounts/create-account.ts

@@ -18,19 +18,16 @@ const initializeCreatedAccount = async ({
   config: AccountsConfig
   phone?: PhoneNumber
 }): Promise<Account | ApplicationError> => {
-  const newWallet = (currency: WalletCurrency) =>
-    WalletsRepository().persistNew({
-      accountId: account.id,
-      type: WalletType.Checking,
-      currency,
-    })
-
   const walletsEnabledConfig = config.initialWallets
 
   // Create all wallets
   const enabledWallets: Partial<Record<WalletCurrency, Wallet>> = {}
   for (const currency of walletsEnabledConfig) {
-    const wallet = await newWallet(currency)
+    const wallet = await WalletsRepository().persistNew({
+      accountId: account.id,
+      type: WalletType.Checking,
+      currency,
+    })
     if (wallet instanceof Error) return wallet
     enabledWallets[currency] = wallet
   }

core/api/test/helpers/random.ts

@@ -9,3 +9,5 @@ export const randomPhone = () =>
   `+1415${Math.floor(Math.random() * 9000000 + 1000000)}` as PhoneNumber
 
 export const randomUserId = () => randomUUID() as UserId
+
+export const randomDeviceId = () => randomUUID() as DeviceId

core/api/test/helpers/user.ts

@@ -20,12 +20,10 @@ import { Account } from "@/services/mongoose/schema"
 
 import { baseLogger } from "@/services/logger"
 
-import { Accounts, Wallets } from "@/app"
+import { Wallets } from "@/app"
 
 import { sleep } from "@/utils"
 
-import { AccountLevel, AccountStatus } from "@/domain/accounts"
-
 const accounts = AccountsRepository()
 
 export const getAccountByPhone = async (phone: PhoneNumber): Promise<Account> => {
@@ -180,30 +178,6 @@ export const createUserAndWalletFromPhone = async (
   }
 }
 
-export const createAccount = async ({
-  initialWallets,
-  userId,
-}: {
-  initialWallets: WalletCurrency[]
-  userId?: UserId
-}) => {
-  const phone = randomPhone()
-
-  const kratosUserId = userId || randomUserId()
-
-  const account = await Accounts.createAccountWithPhoneIdentifier({
-    newAccountInfo: { phone, kratosUserId },
-    config: {
-      initialStatus: AccountStatus.Active,
-      initialWallets,
-      initialLevel: AccountLevel.One,
-    },
-  })
-  if (account instanceof Error) throw account
-
-  return account
-}
-
 export const createRandomUserAndBtcWallet = async () => {
   const phone = randomPhone()
   return createUserAndWallet(phone)

core/api/test/legacy-integration/app/users/user-wallets.spec.ts → core/api/test/integration/app/accounts/create-account.spec.ts

@@ -1,16 +1,26 @@
+import { Accounts } from "@/app"
+
+import { AccountLevel, AccountStatus } from "@/domain/accounts"
 import { WalletCurrency } from "@/domain/shared"
+
 import { AccountsRepository, WalletsRepository } from "@/services/mongoose"
 
-import { createAccount } from "test/helpers"
+import { randomPhone, randomUserId } from "test/helpers"
 
-describe("Users - wallets", () => {
-  describe("with 'createUser'", () => {
+describe("createAccountWithPhoneIdentifier", () => {
+  describe("initialWallets", () => {
     it("adds a USD wallet for new user if config is set to true", async () => {
       const initialWallets = [WalletCurrency.Btc, WalletCurrency.Usd]
 
-      let account: Account | RepositoryError = await createAccount({
-        initialWallets,
+      let account = await Accounts.createAccountWithPhoneIdentifier({
+        newAccountInfo: { phone: randomPhone(), kratosUserId: randomUserId() },
+        config: {
+          initialLevel: AccountLevel.One,
+          initialStatus: AccountStatus.Active,
+          initialWallets,
+        },
       })
+      if (account instanceof Error) throw account
 
       // Check all wallets were created
       const wallets = await WalletsRepository().listByAccountId(account.id)
@@ -36,9 +46,16 @@ describe("Users - wallets", () => {
     it("does not add a USD wallet for new user if config is set to false", async () => {
       const initialWallets = [WalletCurrency.Btc]
 
-      let account: Account | RepositoryError = await createAccount({
-        initialWallets,
-      })
+      let account: Account | RepositoryError =
+        await Accounts.createAccountWithPhoneIdentifier({
+          newAccountInfo: { phone: randomPhone(), kratosUserId: randomUserId() },
+          config: {
+            initialLevel: AccountLevel.One,
+            initialStatus: AccountStatus.Active,
+            initialWallets,
+          },
+        })
+      if (account instanceof Error) throw account
 
       // Check all wallets were created
       const wallets = await WalletsRepository().listByAccountId(account.id)
@@ -64,9 +81,16 @@ describe("Users - wallets", () => {
     it("sets USD wallet as default if BTC wallet does not exist", async () => {
       const initialWallets = [WalletCurrency.Usd]
 
-      let account: Account | RepositoryError = await createAccount({
-        initialWallets,
-      })
+      let account: Account | RepositoryError =
+        await Accounts.createAccountWithPhoneIdentifier({
+          newAccountInfo: { phone: randomPhone(), kratosUserId: randomUserId() },
+          config: {
+            initialLevel: AccountLevel.One,
+            initialStatus: AccountStatus.Active,
+            initialWallets,
+          },
+        })
+      if (account instanceof Error) throw account
 
       // Check all wallets were created
       const wallets = await WalletsRepository().listByAccountId(account.id)

core/api/test/integration/app/user/update-language.spec.ts

@@ -0,0 +1,22 @@
+import { Users } from "@/app"
+import { InvalidLanguageError } from "@/domain/errors"
+
+import { createUserAndWalletFromPhone, getUserIdByPhone, randomPhone } from "test/helpers"
+
+let userId: UserId
+const phone = randomPhone()
+
+beforeAll(async () => {
+  await createUserAndWalletFromPhone(phone)
+  userId = await getUserIdByPhone(phone)
+})
+
+describe("UserUpdateLanguage", () => {
+  it("fails with invalid language", async () => {
+    const result = await Users.updateLanguage({
+      userId: userId,
+      language: "Klingon",
+    })
+    expect(result).toBeInstanceOf(InvalidLanguageError)
+  })
+})

core/api/test/legacy-integration/services/dealer/hedge-price.spec.ts

@@ -1,7 +1,8 @@
-import { Payments, Wallets } from "@/app"
+import { Accounts, Payments, Wallets } from "@/app"
 import { getMidPriceRatio } from "@/app/prices"
 import { getDealerConfig } from "@/config"
 
+import { AccountLevel, AccountStatus } from "@/domain/accounts"
 import { toSats } from "@/domain/bitcoin"
 import { toCents } from "@/domain/fiat"
 import { SubOneCentSatAmountForUsdSelfSendError } from "@/domain/payments"
@@ -17,7 +18,6 @@ import { AccountsRepository, WalletsRepository } from "@/services/mongoose"
 import {
   bitcoindClient,
   bitcoindOutside,
-  createAccount,
   createMandatoryUsers,
   fundLnd,
   fundWallet,
@@ -28,6 +28,8 @@ import {
   loadBitcoindWallet,
   mineAndConfirm,
   openChannelTesting,
+  randomPhone,
+  randomUserId,
   resetLegacyIntegrationLnds,
 } from "test/helpers"
 
@@ -128,9 +130,15 @@ if (usdFundingAmount instanceof Error) throw usdFundingAmount
 
 const newAccountAndWallets = async () => {
   const initialWallets = [WalletCurrency.Btc, WalletCurrency.Usd]
-  const account: Account | RepositoryError = await createAccount({
-    initialWallets,
+  const account = await Accounts.createAccountWithPhoneIdentifier({
+    newAccountInfo: { phone: randomPhone(), kratosUserId: randomUserId() },
+    config: {
+      initialStatus: AccountStatus.Active,
+      initialWallets,
+      initialLevel: AccountLevel.One,
+    },
   })
+  if (account instanceof Error) throw account
 
   const accountId = account.id
   const accountWallets =