test(core): add wait for notifications service

core/api/test/helpers/shared.ts

@@ -1,7 +1,21 @@
+import { NotificationsServiceUnreachableServerError } from "@/domain/notifications"
+
+import { NotificationsService } from "@/services/notifications"
+
 import { sleep } from "@/utils"
 
+import { randomUserId } from "./random"
+
 export const waitFor = async (f: () => Promise<unknown>) => {
   let res
   while (!(res = await f())) await sleep(500)
   return res
 }
+
+// Note: this is to fix flakiness with notifications service health check. This waiting
+//       should eventually happen in the tiltfile somehow.
+export const waitForNotificationsService = () =>
+  waitFor(async () => {
+    const res = await NotificationsService().getUserNotificationSettings(randomUserId())
+    return !(res instanceof NotificationsServiceUnreachableServerError)
+  })

core/api/test/integration/scenarios/hedge-arbitrage.spec.ts

@@ -31,6 +31,7 @@ import {
   randomPhone,
   randomUserId,
   resetLegacyIntegrationLnds,
+  waitForNotificationsService,
 } from "test/helpers"
 
 class ZeroAmountForUsdRecipientError extends Error {}
@@ -65,6 +66,7 @@ beforeAll(async () => {
   await loadBitcoindWallet("outside")
   await resetLegacyIntegrationLnds()
   await bootstrapLndNodes()
+  await waitForNotificationsService()
 })
 
 afterAll(async () => {

core/api/test/integration/services/notifications.spec.ts

@@ -5,6 +5,12 @@ import { toSats } from "@/domain/bitcoin"
 
 import { NotificationsService } from "@/services/notifications"
 
+import { waitForNotificationsService } from "test/helpers"
+
+beforeAll(async () => {
+  await waitForNotificationsService()
+})
+
 describe("NotificationsService", () => {
   describe("sendTransaction", () => {
     it("should send a notification", async () => {