feat: add pending tx queries #3488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
UncleSamtoshi
commented
Nov 2, 2023
UncleSamtoshi
commented
- add pendingTransactions to Account and Wallet GQL objects
- add pendingTransactionsByAddress to Wallet objects
UncleSamtoshi
force-pushed
the
add-pending-txs-fields
branch
from
a1e0317 to
6e007ea
Compare
dolcalmi
requested changes
Nov 3, 2023
|
|
||
| import { WalletOnChainPendingReceiveRepository } from "@/services/mongoose" | ||
|
|
||
| export const getPendingTransactionsForWalletsByAddresses = async ({ |
There was a problem hiding this comment.
I know wallets are passed from source but we must enforce in app layer that wallets belong the user/account (similar to logic in getPendingOnChainTransactionsForAccountByWalletIds)
There was a problem hiding this comment.
I dont necessarily agree with that. The function does what it says which is getPendingTransactionsForWalletsByAddress. It's different than the getPendingOnChainTransactionsForAccountByWalletIds which says its getting them for a specific account and therefore must verify that the account owns the wallets. I think this is a pretty common pattern across the app layer.
UncleSamtoshi
force-pushed
the
add-pending-txs-fields
branch
2 times, most recently
from
8416188 to
97c2705
Compare
UncleSamtoshi
force-pushed
the
add-pending-txs-fields
branch
from
97c2705 to
c57fb82
Compare
dolcalmi
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.