Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added sorted_multisig #258

Merged
merged 26 commits into from
Jul 5, 2023
Merged

feat: added sorted_multisig #258

merged 26 commits into from
Jul 5, 2023

Conversation

thevaibhav-dixit
Copy link
Contributor

No description provided.

@thevaibhav-dixit thevaibhav-dixit changed the title Add sortedmultisig feat: added sorted_multisig Jun 30, 2023
src/api/server/mod.rs Show resolved Hide resolved
src/app/error.rs Outdated Show resolved Hide resolved
src/app/error.rs Outdated Show resolved Hide resolved
src/cli/mod.rs Outdated Show resolved Hide resolved
src/job/batch_signing.rs Outdated Show resolved Hide resolved
src/job/batch_signing.rs Outdated Show resolved Hide resolved
src/job/batch_signing.rs Outdated Show resolved Hide resolved
src/job/batch_signing.rs Outdated Show resolved Hide resolved
tests/e2e/helpers.bash Outdated Show resolved Hide resolved
tests/e2e/helpers.bash Outdated Show resolved Hide resolved
src/api/server/convert.rs Outdated Show resolved Hide resolved
src/app/error.rs Outdated Show resolved Hide resolved
src/app/mod.rs Outdated Show resolved Hide resolved
tests/e2e/bitcoind_sync.bats Outdated Show resolved Hide resolved
tests/e2e/helpers.bash Outdated Show resolved Hide resolved
tests/e2e/multisig_payout.bats Outdated Show resolved Hide resolved
tests/e2e/multisig_payout.bats Outdated Show resolved Hide resolved
tests/e2e/multisig_payout.bats Outdated Show resolved Hide resolved
tests/e2e/helpers.bash Outdated Show resolved Hide resolved
tests/e2e/multisig_payout.bats Outdated Show resolved Hide resolved
tests/e2e/helpers.bash Outdated Show resolved Hide resolved
@thevaibhav-dixit thevaibhav-dixit marked this pull request as ready for review July 4, 2023 13:59
#[test]
fn passes_if_correct_and_signed_psbt_passed() {
let xpub = XPub::try_from(("tpubDE8HT914zGpxhJhgoMX35xgNyjHy5d1neGXHjTLAtuUssTA7tNWNs177JsFPbJwD5FBXCHJYbwUC9AzSEpYHC4hKgaCvZyZTuCbWfNUWXoM", Some("m/48h/1h/0h/2h"))).unwrap();
let signed_psbt = "cHNidP8BAH0BAAAAASNihqnLFfz7pHt1zDeB/iB7ku75Ah6EFaFhQZnbErt9AAAAAAD+////Ap13fQEAAAAAIgAgO37beKyitaViJwyjZ3oTIwdBU0JTbBRa32V1zvdifQzAaHgEAAAAABYAFFPOvhKDbGzCHM0LNEHgSPJjuf7RzQAAAAABAIkCAAAAAUxGIfiVmAY20gYMGPkMWDhNuf7xZOc3UutYyrXNRyY2AAAAAAD9////AgDh9QUAAAAAIgAgjoqVjwo7KNRKWUHLalHhejeEI0zUN3PteWscxop8ElYcBBAkAQAAACJRIM5ovh2uzu6dPIaxxMy66uvDCZUg1uNFd/ZG6kvgK5kzyAAAAAEBKwDh9QUAAAAAIgAgjoqVjwo7KNRKWUHLalHhejeEI0zUN3PteWscxop8ElYBCJIDAEcwRAIgGZdgjGq/M/51nE9WtP69BZBhQtho22JcoIQHSWEXI00CIA7/Mj5A906MFjd+sm+EawhjTALyR5jsPyT6Qa7TEJQDAUdRIQJQZ+FcB64peA2v9qxsxfxWZzNIJwIuTOwO4hzMTAOLSCECl48Dr84329WNBzLx9gXNhKrbpMfncXeFfKjrrNt6hoZSrgABAUdRIQJcOcC8y4Cq1oHFG9ZZErhw54kKafGsebNftiz5M6AuQyECyXb40F/RY1cHkPK7+PT6W4hVgJX7bUZHuE8jYBS+KyJSriICAlw5wLzLgKrWgcUb1lkSuHDniQpp8ax5s1+2LPkzoC5DHJhT3akwAACAAQAAgAAAAIACAACAAQAAAAAAAAAiAgLJdvjQX9FjVweQ8rv49PpbiFWAlfttRke4TyNgFL4rIhwd6KQcMAAAgAEAAIAAAACAAgAAgAEAAAAAAAAAAAA=".parse::<psbt::PartiallySignedTransaction>().unwrap();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit (can fix in another PR) I prefer:

let signed_psbt: psbt::PartialySignedTransaction = "..".parse().unwrap()

@thevaibhav-dixit thevaibhav-dixit merged commit 197a04f into main Jul 5, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants