Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: always use bitcoind configmap checksum #3171

Merged
merged 1 commit into from
May 25, 2023
Merged

fix: always use bitcoind configmap checksum #3171

merged 1 commit into from
May 25, 2023

Conversation

openoms
Copy link
Contributor

@openoms openoms commented May 25, 2023 •
edited
Loading

The predefined annotations including the configmap checksum were not applied if .Values.podAnnotations was empty.

@openoms openoms requested review from bodymindarts and krtk6160 May 25, 2023 10:49
krtk6160
krtk6160 approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@krtk6160 krtk6160 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch!

@openoms openoms merged commit f3ccc17 into main May 25, 2023
@openoms openoms deleted the fix--always-use-bitcoind-configmap-checksum branch May 25, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krtk6160 krtk6160 krtk6160 approved these changes

@bodymindarts bodymindarts Awaiting requested review from bodymindarts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@openoms @krtk6160