Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajout d'un bouton pour retourner a la page d'accueil #44

Merged
merged 7 commits into from
Oct 30, 2024

Conversation

Nguirane120
Copy link
Contributor

No description provided.

Alkaly02 and others added 7 commits October 26, 2024 10:44
You were just adding a back-to-home button, didn't need to define a new
component for our "library".
You were displaying the `back-to-home` button in `ComponentDetails`
 where it was being displayed multiple times.
@NDOY3M4N
Copy link
Member

thx for the PR @Nguirane120!
J'ai apporté quelques modifs au PR par contre

  • supprimer public/components/back-to-home/1.html, src/data/components/galsen-ui-back-to-home.md, src/data/components/galsen-ui-footer-links.mdx
  • deplacer back-to-home button au niveau de app/components/[componentName]/page.tsx

Note

Il y a une boucle sur ComponentDetails et tu avais placé le button là-bas (y'avait répétition du button). C'est pourquoi j'ai placé le button au niveau de page.tsx.

@NDOY3M4N NDOY3M4N merged commit 79ccdeb into GalsenDev221:dev Oct 30, 2024
@Nguirane120
Copy link
Contributor Author

Nguirane120 commented Oct 30, 2024 via email

NDOY3M4N added a commit that referenced this pull request Oct 30, 2024
* Add selects components

* Ajout d'un bouton pour retourner a la page d'accueil (#44)

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Amélioration du footer: ajout de liens fonctionnels

* ajout d'un boutton dans CompnentDetails pour retourner a la page d'accueil

* chore: remove unnecessary component definition

You were just adding a back-to-home button, didn't need to define a new
component for our "library".

* refac: move the back-to-home to `page.tsx`

You were displaying the `back-to-home` button in `ComponentDetails`
 where it was being displayed multiple times.

---------

Co-authored-by: Moussa Alkaly BADJI <89929592+Alkaly02@users.noreply.github.com>
Co-authored-by: Abdoulaye NDOYE <pa.ndoye@outlook.fr>

* feat: use the favicon

* i changed the app favicon (#53)

* i changed the app favicon

* feat: use new favicon

---------

Co-authored-by: Abdoulaye NDOYE <pa.ndoye@outlook.fr>

---------

Co-authored-by: Devdiop221 <diopmouhamed290@gmail.com>
Co-authored-by: Nguirane120 <79750993+Nguirane120@users.noreply.github.com>
Co-authored-by: Moussa Alkaly BADJI <89929592+Alkaly02@users.noreply.github.com>
Co-authored-by: Salem Malick MOHAMED <64892800+saloum45@users.noreply.github.com>
NDOY3M4N added a commit that referenced this pull request Oct 30, 2024
* Add selects components

* Ajout d'un bouton pour retourner a la page d'accueil (#44)

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Amélioration du footer: ajout de liens fonctionnels

* ajout d'un boutton dans CompnentDetails pour retourner a la page d'accueil

* chore: remove unnecessary component definition

You were just adding a back-to-home button, didn't need to define a new
component for our "library".

* refac: move the back-to-home to `page.tsx`

You were displaying the `back-to-home` button in `ComponentDetails`
 where it was being displayed multiple times.

---------

Co-authored-by: Moussa Alkaly BADJI <89929592+Alkaly02@users.noreply.github.com>
Co-authored-by: Abdoulaye NDOYE <pa.ndoye@outlook.fr>

* feat: use the favicon

* i changed the app favicon (#53)

* i changed the app favicon

* feat: use new favicon

---------

Co-authored-by: Abdoulaye NDOYE <pa.ndoye@outlook.fr>

---------

Co-authored-by: Devdiop221 <diopmouhamed290@gmail.com>
Co-authored-by: Nguirane120 <79750993+Nguirane120@users.noreply.github.com>
Co-authored-by: Moussa Alkaly BADJI <89929592+Alkaly02@users.noreply.github.com>
Co-authored-by: Salem Malick MOHAMED <64892800+saloum45@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants