Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: warning on RN v0.65+ #5359

Merged

Conversation

enagorny
Copy link
Contributor

Summary

removeEventListener is deprecated for a several years https://reactnative.dev/docs/0.65/appstate#removeeventlistener

Changelog

[General] [Fix] - Warning on react-native 0.65+

Test Plan

@vercel
Copy link

vercel bot commented Sep 14, 2022

@enagorny is attempting to deploy a commit to the Geekyants Team Team on Vercel.

A member of the Team first needs to authorize it.

@kevindice
Copy link
Contributor

This addresses #5371

@kevindice
Copy link
Contributor

Hi @rayan1810, I've tested this locally and it solves problem for me with React 0.70.1. Could we please get this in the next release? Thanks!

Removing comment.

Co-authored-by: Kevin Dice <kevin.dice1@gmail.com>
@austinrbrown01
Copy link

+1 to please push in next update

@rayan1810 rayan1810 changed the base branch from master to patch October 31, 2022 06:05
@rayan1810 rayan1810 merged commit 45bd6b2 into GeekyAnts:patch Oct 31, 2022
This was referenced Sep 8, 2024
This was referenced Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants