Allocation optimisations & Clippy cleanup #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
I started trying to get the Clippy lints to pass and then I got a bit carried away. I ended up removing all indexing (which could panic) and unwraps. And I found a way to get rid of some intermediate
collect
s by messing with the validity filters (making them safe to share between threads).I also reversed the polarity of the
hash_set_filter
predicate, so that it matchesIterator::filter
.