Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spec: implement bip32 test vectors {3,4,5} #52

Merged
merged 1 commit into from
Jan 3, 2022
Merged

spec: implement bip32 test vectors {3,4,5} #52

merged 1 commit into from
Jan 3, 2022

Conversation

q9f
Copy link
Collaborator

@q9f q9f commented Dec 21, 2021

passes

  • test vector 3
    • m
    • m/0p
  • test vector 4
    • m
    • m/0p
    • m/0'/1p
  • test vector 5 - ref Bip 32 test vector 5 fails 10/16 #51
    • recognizes pubkey version / prvkey mismatch ⚠️
    • recognizes prvkey version / pubkey mismatch ⚠️
    • recognizes invalid pubkey prefix 04
    • recognizes invalid prvkey prefix 04
    • recognizes invalid pubkey prefix 01
    • recognizes invalid prvkey prefix 01
    • recognizes zero depth with non-zero parent fingerprint ⚠️
    • recognizes zero depth with non-zero parent fingerprint ⚠️
    • recognizes zero depth with non-zero index ⚠️
    • recognizes zero depth with non-zero index ⚠️
    • recognizes unknown extended key version ⚠️
    • recognizes unknown extended key version ⚠️
    • recognizes private key 0 not in 1..n-1 ⚠️
    • recognizes private key n not in 1..n-1 ⚠️
    • recognizes invalid pubkey 020000000000000000000000000000000000000000000000000000000000000007
    • recognizes invalid checksum

@q9f q9f merged commit f8eb0ad into master Jan 3, 2022
@q9f q9f deleted the q9f/spec/bip32 branch January 3, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@q9f