Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional constraints to prevent violation of state of charge limits in non-representative periods #781

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

federicoparolin
Copy link

Description

  • Introduced additional constraints to bound the state of charge of LDS systems within the limits (zero and installed energy capacity) throughout the entire time horizon (as described in https://doi.org/10.48550/arXiv.2409.19079).
  • Saving of storage content evolution throughout the entire time horizon (StorageEvol.csv and HSC_StorageEvol.csv)

Storage content evolution over full time horizon with the original (a) and updated (b) formulations:
immagine

What type of PR is this? (check all applicable)

  • Feature
  • Bug Fix
  • Documentation Update
  • Code Refactor
  • Performance Improvements

How this can be tested

Tested on "3_three_zones_w_co2_capture" enabling LDS on storage resources.

Post-approval checklist for GenX core developers

After the PR is approved

  • Check that the latest changes on the target branch are incorporated, either via merge or rebase
  • Remember to squash and merge if incorporating into develop

@RuaridhMacd RuaridhMacd added bug Something isn't working enhancement New feature or request labels Oct 8, 2024
Copy link
Collaborator

@gmantegna gmantegna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just two requests: 1. Can you please modify the relevant doc pages to reflect this change? 2. Do you have an idea of how much this increases runtime? Especially for a large case?

Copy link
Collaborator

@gmantegna gmantegna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you

Copy link
Collaborator

@lbonaldo lbonaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @federicoparolin, thanks so much for this PR! It looks great to me as well. I’ve added a few additional comments on the write_opwrap_lds_stor_init function, could you please take a look when you have a moment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants