-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional constraints to prevent violation of state of charge limits in non-representative periods #781
base: main
Are you sure you want to change the base?
Conversation
… in non-representative periods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just two requests: 1. Can you please modify the relevant doc pages to reflect this change? 2. Do you have an idea of how much this increases runtime? Especially for a large case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you
src/write_outputs/long_duration_storage/write_opwrap_lds_stor_init.jl
Outdated
Show resolved
Hide resolved
src/write_outputs/long_duration_storage/write_opwrap_lds_stor_init.jl
Outdated
Show resolved
Hide resolved
src/write_outputs/long_duration_storage/write_opwrap_lds_stor_init.jl
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @federicoparolin, thanks so much for this PR! It looks great to me as well. I’ve added a few additional comments on the write_opwrap_lds_stor_init
function, could you please take a look when you have a moment?
Description
Storage content evolution over full time horizon with the original (a) and updated (b) formulations:
What type of PR is this? (check all applicable)
How this can be tested
Tested on "3_three_zones_w_co2_capture" enabling LDS on storage resources.
Post-approval checklist for GenX core developers
After the PR is approved