Refactor text to use virtualfile_from_data #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
changed the title
seisman
changed the title
5 tasks
maxrjones
approved these changes
Apr 15, 2021
pygmt/src/text.py
Outdated
| @@ -203,19 +204,15 @@ def text_( | |||
| extra_arrays.append(kwargs["t"]) | |||
| kwargs["t"] = "" | |||
|
|
|||
| # Append text as the last column | |||
| # text must be in str type, see issue #706 | |||
There was a problem hiding this comment.
Should be fixed now, correct?
Suggested change
| # text must be in str type, see issue #706 |
There was a problem hiding this comment.
text must be in str type
This statement is still True.
core-man
reviewed
Apr 15, 2021
|
Thanks for your suggestions. I'll mark this PR as draft, because I don't like the current implemention. |
5 tasks
Closed
6 tasks
seisman
commented
May 14, 2022
Co-authored-by: Max Jones <meghanj@alum.mit.edu>
I plan to not make more reactors in this PR to make it easier to review. |
weiji14
reviewed
May 16, 2022
weiji14
added
the
final review call
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
|
Ping @meghanrjones to give this PR a final review. |
seisman
removed
the
final review call
|
Sorry for not getting back to this in time to be helpful |
|
No worries. You can still leave your comments if there are any 😄 |
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
Co-authored-by: Max Jones <meghanj@alum.mit.edu> Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
virtualfile_from_dataRelated to #949.
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version