-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor blockm* to use virtualfile_from_data and improve i/o #1280
Conversation
The docstring for |
Since geopandas is now supported and included in {table-like} filler text, do I also need to add tests for geopandas input? |
I think it's unnecessary. The geopandas support is independent with any specific modules and we already have it tested in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Meghan for the work, I think we can close #1099 with this PR too no?
Since geopandas is now supported and included in {table-like} filler text, do I also need to add tests for geopandas input?
I think it's unnecessary. The geopandas support is independent with any specific modules and we already have it tested in the
test_geopandas.py
file.
Agree that we don't need a geopandas
input test here.
However, this got me to think about how the PyGMT I/O should work if a geopandas.GeoDataFrame
is used as an input to blockm*
. Should we yield a pandas.DataFrame
output, or would users prefer a geopandas.GeoDataFrame
to be returned here? Something to think about in a separate issue.
Yes, it is now linked.
Some users would probably like the option. This could be a good SciPy sprint issue. |
What's still missing is |
Ah ok, I've unlinked #1099 from being closed. We'll handle the x/y/z inputs for |
…cMappingTools#1280) - Enables blockm* to work with table-like inputs besides pandas.DataFrame - Makes outfile parameter optional - Loads output data as a pandas.DataFrame when outfile is unset - Updates unit tests accordingly
Description of proposed changes
This PR makes the changes corresponding to #1189 for blockmean and blockmedian.
Related to #949. Addresses #1099
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version