Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the invalid comment 'Choose how data will be passed ...' #2721

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

seisman
Copy link
Member

@seisman seisman commented Oct 7, 2023

Description of proposed changes

The comment "Choose how data will be passed into the module" is invalid after we replace virtualfile_from_grid/matrix/vectors to virtualfile_from_data in #949, because we don't choose now (actually we still make choices but the logic is hidden in the virtualfile_from_data function).

Note: grdtrack.py is left intact because it will be addressed in PR #2708

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Oct 7, 2023
@seisman seisman added this to the 0.11.0 milestone Oct 7, 2023
@seisman seisman added the needs review This PR has higher priority and needs review. label Oct 7, 2023
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Oct 8, 2023
@seisman seisman merged commit 89708c3 into main Oct 9, 2023
13 of 15 checks passed
@seisman seisman deleted the cleanup-comments branch October 9, 2023 03:58
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants