Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the 'Conventions' attribute to 'CF-1.7' for netCDF grids only #3463

Merged
merged 18 commits into from
Sep 28, 2024

Conversation

seisman
Copy link
Member

@seisman seisman commented Sep 28, 2024

Conventions="CF-1.7" only makes sense for netCDF grids.

The issue was originally found and fixed in 5888e10 (PR #3128). It is further refactored after adding the GridFormat enums in PR #3449.

Waiting for #3449 first.

@seisman seisman added the bug Something isn't working label Sep 28, 2024
@seisman seisman added this to the 0.14.0 milestone Sep 28, 2024
@seisman seisman added the needs review This PR has higher priority and needs review. label Sep 28, 2024
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved to merge after #3449

@seisman seisman removed the needs review This PR has higher priority and needs review. label Sep 28, 2024
Base automatically changed from enums/gridid to main September 28, 2024 13:11
@seisman seisman merged commit cf48764 into main Sep 28, 2024
15 of 18 checks passed
@seisman seisman deleted the bug/convention branch September 28, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants