Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Figure.shift_origin tests into a separate test file #3590

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

seisman
Copy link
Member

@seisman seisman commented Nov 6, 2024

Description of proposed changes

Figure.shift_origin source code was moved from pygmt/figure.py to pygmt/src/shift_origin.py in #2485. It make sense to have a separate test file for Figure.shift_origin.

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog needs review This PR has higher priority and needs review. labels Nov 6, 2024
@seisman seisman added this to the 0.14.0 milestone Nov 6, 2024
@seisman seisman closed this Nov 6, 2024
@seisman seisman reopened this Nov 6, 2024
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
added pygmt/tests/baseline/test_shift_origin.png
deleted pygmt/tests/baseline/test_figure_shift_origin.png

Image diff(s)

Added images

  • test_shift_origin.png

Modified images

Path Old New

Report last updated at commit feedcc8

@seisman
Copy link
Member Author

seisman commented Nov 6, 2024

The Windows CI failure is likely caused by micromamba 2.0.3 released a few hours ago (https://github.com/mamba-org/micromamba-releases/releases/tag/2.0.3-0).

@seisman
Copy link
Member Author

seisman commented Nov 6, 2024

The Windows CI failure is likely caused by micromamba 2.0.3 released a few hours ago (https://github.com/mamba-org/micromamba-releases/releases/tag/2.0.3-0).

Upstream issue report at mamba-org/mamba#3576.

@seisman seisman merged commit 50c8980 into main Nov 7, 2024
21 of 31 checks passed
@seisman seisman deleted the tests/shift_origin branch November 7, 2024 03:01
@seisman seisman removed the needs review This PR has higher priority and needs review. label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants