Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor grd modules to use virtualfile_from_data #992

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Refactor grd modules to use virtualfile_from_data #992

merged 1 commit into from
Mar 3, 2021

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Mar 3, 2021 •
edited
Loading

Description of proposed changes

Remove duplicated code in grd2cpt, grdcontour, grdcut, grdfilter, grdimage, grdtrack, and grdview.

Will need a bit of extra thinking for parts of grdtrack and grdview (will do in a separate PR).

Part of #949

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@weiji14
Refactor grd modules to use virtualfile_from_data
5362fb4 
Remove duplicated code in grd2cpt, grdcontour,
grdcut, grdfilter, grdimage, grdtrack, and grdview.
@weiji14 weiji14 added the maintenance Boring but important stuff for the core devs label Mar 3, 2021
@weiji14 weiji14 marked this pull request as ready for review March 3, 2021 03:02
@weiji14 weiji14 merged commit 10482f3 into master Mar 3, 2021
@weiji14 weiji14 deleted the virtualfile_from_data/grd_modules branch March 3, 2021 03:33
@seisman seisman added this to the 0.3.1 milestone Mar 3, 2021
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@weiji14
Refactor grd modules to use virtualfile_from_data (GenericMappingTool…
39f5ae2 
…s#992)

Remove duplicated if-elif-else code in grd2cpt, grdcontour,
grdcut, grdfilter, grdimage, grdtrack, and grdview through
the use of the virtualfile_from_data function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seisman seisman seisman approved these changes

Assignees
No one assigned
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Milestone
0.3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@weiji14 @seisman