Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#453: Introduced native tls support #454

Merged
merged 2 commits into from
Nov 3, 2021
Merged

#453: Introduced native tls support #454

merged 2 commits into from
Nov 3, 2021

Conversation

AndreRudolph
Copy link
Contributor

#453: Introduced native tls support by using the React/Socket/SecureServer implementation.

@mbabker
Copy link
Contributor

mbabker commented Nov 3, 2021

I tweaked this to inject the TLS config directly to the WebSocketServer class since the options aren't easily configured at launch time through the command (essentially the same way you can use the host/port options to override the bundle config values) and to avoid the B/C issues with tweaking interfaces.

Thanks for the PR!

@mbabker mbabker merged commit 2239781 into GeniusesOfSymfony:3.x Nov 3, 2021
@mbabker mbabker linked an issue Nov 3, 2021 that may be closed by this pull request
Suggestion: Native TLS support #453
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nitpick-CI Nitpick-CI Nitpick-CI left review comments

Assignees
No one assigned
Labels
enhancement feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggestion: Native TLS support
3 participants
@AndreRudolph @mbabker @Nitpick-CI