Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/admin-creator-find #147

Merged
merged 3 commits into from
Sep 2, 2024
Merged

feat/admin-creator-find #147

merged 3 commits into from
Sep 2, 2024

Conversation

BYEONGRYEOL
Copy link
Member

No description provided.

@BYEONGRYEOL BYEONGRYEOL requested a review from LeeJae-H August 29, 2024 14:26
@BYEONGRYEOL BYEONGRYEOL self-assigned this Aug 29, 2024
@LeeJae-H
Copy link
Collaborator

Withdraw -> Cashout 확인했습니다!

해당 branch pull해서 확인했을 때,
image
image
이미지들처럼 몇개 남아있는데, 그냥 납둘까요 아니면 수정할까요??
수정해야된다면 제가 수정한 후 커밋얹겠습니다..!

@BYEONGRYEOL
Copy link
Member Author

아 도메인 관련해서는 그러면 죄송한데 제가 졸려서 자세히 못다뤘는데요,

제 사고회로를 보여드릴게요

  1. 도메인 java class까지 이름을 변경하면 db table 명도 바꿔야한다. 혹시 안맞게 될까바 냅둬야겠다.
  2. class 파일명과 바라보는 db table명을 따로 지정할 수 있지만 그럴거면 바꾸는게 낫다

해서 어드민쪽에서 기능 필요한부분 빨리 달라고해서 싱싱미역상태에서 이렇게 했는데, 오늘 저녁에 싹 바꾸겠습니다 머지하지말아주세요!

@LeeJae-H
Copy link
Collaborator

넵 확인했습니다

@BYEONGRYEOL BYEONGRYEOL merged commit 52d6bac into dev Sep 2, 2024
@LeeJae-H LeeJae-H deleted the feat/admin-creator-find branch September 30, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants