Unable to list camera sizes on S20+ #4852
Comments
|
Realized this may be due to the 5th camera being a depth sensor that can't be grabbed like a normal device |
|
Thank you for your report. Could you please retry with these changes: diff --git a/server/src/main/java/com/genymobile/scrcpy/CameraCapture.java b/server/src/main/java/com/genymobile/scrcpy/CameraCapture.java
index a1003829f..df3cf7c4f 100644
--- a/server/src/main/java/com/genymobile/scrcpy/CameraCapture.java
+++ b/server/src/main/java/com/genymobile/scrcpy/CameraCapture.java
@@ -127,6 +127,10 @@ public class CameraCapture extends SurfaceCapture {
StreamConfigurationMap configs = characteristics.get(CameraCharacteristics.SCALER_STREAM_CONFIGURATION_MAP);
android.util.Size[] sizes = highSpeed ? configs.getHighSpeedVideoSizes() : configs.getOutputSizes(MediaCodec.class);
+ if (sizes == null) {
+ return null;
+ }
+
Stream<android.util.Size> stream = Arrays.stream(sizes);
if (maxSize > 0) {
stream = stream.filter(it -> it.getWidth() <= maxSize && it.getHeight() <= maxSize);
diff --git a/server/src/main/java/com/genymobile/scrcpy/LogUtils.java b/server/src/main/java/com/genymobile/scrcpy/LogUtils.java
index efa0672b7..1ffb19d3c 100644
--- a/server/src/main/java/com/genymobile/scrcpy/LogUtils.java
+++ b/server/src/main/java/com/genymobile/scrcpy/LogUtils.java
@@ -118,12 +118,16 @@ public final class LogUtils {
StreamConfigurationMap configs = characteristics.get(CameraCharacteristics.SCALER_STREAM_CONFIGURATION_MAP);
android.util.Size[] sizes = configs.getOutputSizes(MediaCodec.class);
- for (android.util.Size size : sizes) {
- builder.append("\n - ").append(size.getWidth()).append('x').append(size.getHeight());
+ if (sizes == null || sizes.length == 0) {
+ builder.append("\n (none)");
+ } else {
+ for (android.util.Size size : sizes) {
+ builder.append("\n - ").append(size.getWidth()).append('x').append(size.getHeight());
+ }
}
android.util.Size[] highSpeedSizes = configs.getHighSpeedVideoSizes();
- if (highSpeedSizes.length > 0) {
+ if (highSpeedSizes != null && highSpeedSizes.length > 0) {
builder.append("\n High speed capture (--camera-high-speed):");
for (android.util.Size size : highSpeedSizes) {
Range<Integer>[] highFpsRanges = configs.getHighSpeedVideoFpsRanges();Here is a server binary including the changes (for scrcpy v2.4).
|
|
That seems to have worked! |
|
Side note: I can do 1080 60 for video recording but this seems to not list it? Camera ID 0 says max of 30 and when I trying specifying ID 0 size 1080 and FPS 60 I get Camera capture failed.
|
Merged bcb8503 into
Looks like #4675. Can you record at 1080p 60fps with another camera app (like OpenCamera)? |
FreedomBen
pushed a commit
to FreedomBen/scrcpy
that referenced
this issue
Aug 2, 2024
The array of sizes may be null. Handle this case gracefully. Fixes Genymobile#4852 <Genymobile#4852>
Gottox
pushed a commit
to Gottox/scrcpy
that referenced
this issue
Sep 29, 2024
The array of sizes may be null. Handle this case gracefully. Fixes Genymobile#4852 <Genymobile#4852>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Environment
Describe the bug
Listing cameras works as expected but then going to list sizes results in a crash.
On errors, please provide the output of the console (and
adb logcatif relevant).The text was updated successfully, but these errors were encountered: