[Fixes #976] Fix missing required accessToken for MapBox background w…

…hen adding a map to a geostory (#1014) (#1041)
GeoNode · Jun 20, 2022 · 22f3b72 · 22f3b72
1 parent a798b15
commit 22f3b72
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 5 deletions.
diff --git a/geonode_mapstore_client/client/MapStore2 b/geonode_mapstore_client/client/MapStore2
diff --git a/geonode_mapstore_client/client/js/plugins/Share.jsx b/geonode_mapstore_client/client/js/plugins/Share.jsx
@@ -6,7 +6,7 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-import React, { useEffect, useState } from 'react';
+import React, { useEffect, useState, useRef } from 'react';
 import PropTypes from 'prop-types';
 import { connect } from 'react-redux';
 import { createSelector } from 'reselect';
@@ -97,6 +97,14 @@ function Share({
     embedUrl
 }) {
 
+    const isMounted = useRef(false);
+    useEffect(() => {
+        isMounted.current = true;
+        return () => {
+            isMounted.current = false;
+        };
+    }, []);
+
     const [permissionsObject, setPermissionsObject] = useState({});
     useEffect(() => {
         getResourceTypes().then((data) => {
@@ -107,7 +115,9 @@ function Share({
             } else { // set a default permission object
                 responseOptions = getResourcePermissions(data[0].allowed_perms.compact);
             }
-            setPermissionsObject(responseOptions);
+            if (isMounted.current) {
+                setPermissionsObject(responseOptions);
+            }
         });
     }, [availableResourceTypes]);
 

diff --git a/geonode_mapstore_client/client/js/plugins/layersettings/WMSLayerSettings.jsx b/geonode_mapstore_client/client/js/plugins/layersettings/WMSLayerSettings.jsx
@@ -14,7 +14,7 @@ import Button from '@js/components/Button';
 import IntlNumberFormControl from '@mapstore/framework/components/I18N/IntlNumberFormControl';
 import Message from '@mapstore/framework/components/I18N/Message';
 import InfoPopover from '@mapstore/framework/components/widgets/widget/InfoPopover';
-import { DEFAULT_FORMAT_WMS, getSupportedFormat } from '@mapstore/framework/utils/CatalogUtils';
+import { DEFAULT_FORMAT_WMS, getSupportedFormat } from '@mapstore/framework/api/WMS';
 import { getConfigProp } from '@mapstore/framework/utils/ConfigUtils';
 import LegendImage from '@mapstore/framework/components/TOC/fragments/legend/Legend';
 import Select from 'react-select';

diff --git a/geonode_mapstore_client/client/package.json b/geonode_mapstore_client/client/package.json
@@ -26,7 +26,7 @@
   "author": "GeoSolutions",
   "license": "BSD-2-Clause",
   "devDependencies": {
-    "@mapstore/project": "1.0.21",
+    "@mapstore/project": "1.0.23",
     "dotenv": "10.0.0",
     "jsdoc-to-markdown": "7.1.0"
   },
@@ -37,6 +37,7 @@
     "font-awesome": "4.7.0",
     "mapstore": "file:MapStore2",
     "react-helmet": "6.1.0",
+    "react-intl": "2.3.0",
     "three": "0.136.0"
   },
   "mapstore": {

diff --git a/geonode_mapstore_client/templates/geonode-mapstore-client/_geonode_config.html b/geonode_mapstore_client/templates/geonode-mapstore-client/_geonode_config.html
@@ -16,6 +16,8 @@
 {% generate_proxyurl PROXY_URL|default:"/proxy/?url=" request as UPDATED_PROXY_URL %}
 {% retrieve_apikey request as user_apikey %}
 
+{% mapbox_access_token as MAPBOX_ACCESS_TOKEN %}
+
 <script>
     (function(){
 
@@ -102,6 +104,7 @@
                 extensionsFolder: extensionsFolder,
                 printUrl: geoServerPublicLocation + 'pdf/info.json',
                 bingApiKey: '{% bing_api_key %}',
+                mapboxAccessToken: '{{ MAPBOX_ACCESS_TOKEN }}',
                 geoNodeApi: {
                     endpointV1: siteUrl + 'api',
                     endpointV2: siteUrl + 'api/v2'