Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View Geostory/Dashboard loggs KeyError #560

Closed
marthamareal opened this issue Nov 2, 2021 · 3 comments
Closed

View Geostory/Dashboard loggs KeyError #560

marthamareal opened this issue Nov 2, 2021 · 3 comments
Assignees
Milestone

Comments

@marthamareal
Copy link

On viewing a geoApp(Geostory/ Dashboard) A key error is logged here
Geoapp viewer_obj has no attribute about.

branch 3.3.x

@giohappy
Copy link

that's strange @marthamareal. The convert method (and the viewer_obj) should only be used for maps, not geoaapps. Can you please invetigate why we're hitting that methog for geoapps?

@marthamareal
Copy link
Author

@giohappy We are hitting the convert method because in the hooksets for geoapps(eg geoapp_new_template ) , the initialize_context function is used and in it the convert is used here. (callback defined here.

@giohappy
Copy link

giohappy commented Dec 7, 2021

ok @marthamareal so in that acse let's use a get for the about property, and check for its existence before using it. Please do it on master too.

@giohappy giohappy added this to the 3.3.0 milestone Dec 7, 2021
marthamareal added a commit to marthamareal/geonode-mapstore-client that referenced this issue Dec 9, 2021
marthamareal added a commit to marthamareal/geonode-mapstore-client that referenced this issue Dec 9, 2021
@giohappy giohappy modified the milestones: 3.3.0, 3.3.1 Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants