Implement MediaViewer Plugin #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@MuhweziDeo The implementation seems good, could you add some testing to this new components?
|
MuhweziDeo
commented
Jun 14, 2021
geonode_mapstore_client/client/themes/geonode/scss/geonode.scss
Outdated
Show resolved
Hide resolved
allyoucanmap
approved these changes
Jun 14, 2021
marthamareal
pushed a commit
to marthamareal/geonode-mapstore-client
that referenced
this pull request
Jun 29, 2021
* Show Featured Items (GeoNode#197) * Client - Display number of active filters (GeoNode#239) * Implement MediaViewer Plugin (GeoNode#212) * check for perms undefined (GeoNode#241) * Client - Filter form sends requests when the value field is changed (GeoNode#219) * Improve structure of viewers (GeoNode#242) Co-authored-by: Muhwezi Deo <39124174+MuhweziDeo@users.noreply.github.com> Co-authored-by: Luca Orlandini <luca.orlandini@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement media viewer plugin for images, video, pdf files