[Backport 4.1.x] [Backport 4.0.x] [Fixes #9041] Docker NGINX listen on ports 80/443

[github-actions]

Backport ed06660 from #10340

[cla-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @github-actions[bot] on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

[codecov]

Codecov Report

Merging #10343 (b06dfc5) into 4.1.x (fcfe47f) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##            4.1.x   #10343   +/-   ##
=======================================
  Coverage   61.91%   61.92%           
=======================================
  Files         827      827           
  Lines       50865    50865           
  Branches     6549     6549           
=======================================
+ Hits        31494    31496    +2     
+ Misses      17688    17685    -3     
- Partials     1683     1684    +1     

[gannebamm]

This commit leads to a non-working default docker-compose. If I fetch and build the Nginx container will throw this error:

022/11/25 10:10:37 [emerg] 1#1: host not found in "$HTTP_PORT" of the "listen" directive in /etc/nginx/nginx.conf:25
2022-11-25T10:10:42.820832090Z nginx: [emerg] host not found in "$HTTP_PORT" of the "listen" directive in /etc/nginx/nginx.conf:25

I did not change anything else, and it is a fresh build. After reverting the commit, the setup starts properly

[gannebamm]

As said by Frafra:

Users could still experience this issue after applying the patch, if they do not delete the nginx-confd volume. I would actually suggest keeping that volume disabled by default, so that the configuration is created each time, by looking at the environment variables.

There actually was a dangling nginx-confd volume I did not delete first. Sorry for the noise. Everything is fine.