Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #10462] GeoNode is vulnerable to an XML External Entity (XXE) injection #10463

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

afabiani
Copy link
Member

@afabiani afabiani commented Dec 21, 2022

References: #10462

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@afabiani afabiani self-assigned this Dec 21, 2022
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Dec 21, 2022
@afabiani afabiani added this to the 4.1.0 milestone Dec 21, 2022
@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Merging #10463 (df1409a) into master (14a7032) will increase coverage by 0.00%.
The diff coverage is 77.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10463   +/-   ##
=======================================
  Coverage   61.94%   61.95%           
=======================================
  Files         827      827           
  Lines       50900    50904    +4     
  Branches     6551     6551           
=======================================
+ Hits        31532    31538    +6     
+ Misses      17686    17683    -3     
- Partials     1682     1683    +1     

@afabiani afabiani merged commit 348291d into master Dec 22, 2022
@afabiani afabiani deleted the ISSUE_10462 branch December 22, 2022 09:50
github-actions bot pushed a commit that referenced this pull request Dec 22, 2022
github-actions bot pushed a commit that referenced this pull request Dec 22, 2022
afabiani added a commit that referenced this pull request Dec 22, 2022
…injection (#10463) (#10466)

Co-authored-by: Alessio Fabiani <alessio.fabiani@geosolutionsgroup.com>
afabiani added a commit that referenced this pull request Dec 22, 2022
…injection (#10463) (#10467)

Co-authored-by: Alessio Fabiani <alessio.fabiani@geosolutionsgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 4.0.x backport 4.1.x cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants