Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dependencies] Align "setup.cfg" to "requirements.txt" #10555

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

afabiani
Copy link
Member

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@afabiani afabiani added dependencies Pull requests that update a dependency file backport 4.1.x labels Jan 17, 2023
@afabiani afabiani added this to the 4.1.0 milestone Jan 17, 2023
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jan 17, 2023
@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #10555 (2898d1a) into master (a41e575) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10555      +/-   ##
==========================================
- Coverage   62.14%   62.13%   -0.01%     
==========================================
  Files         827      827              
  Lines       51133    51133              
  Branches     6562     6562              
==========================================
- Hits        31775    31773       -2     
- Misses      17673    17676       +3     
+ Partials     1685     1684       -1     

@afabiani afabiani merged commit 33d4aa9 into master Jan 18, 2023
@afabiani afabiani deleted the dependencies_alignment branch January 18, 2023 09:26
github-actions bot pushed a commit that referenced this pull request Jan 18, 2023
afabiani added a commit that referenced this pull request Jan 18, 2023
(cherry picked from commit 33d4aa9)

Co-authored-by: Alessio Fabiani <alessio.fabiani@geosolutionsgroup.com>
ridoo pushed a commit to Thuenen-GeoNode-Development/geonode that referenced this pull request Sep 18, 2023
GeoNode#10558)

(cherry picked from commit 33d4aa9)

Co-authored-by: Alessio Fabiani <alessio.fabiani@geosolutionsgroup.com>
ridoo pushed a commit to Thuenen-GeoNode-Development/geonode that referenced this pull request Feb 22, 2024
GeoNode#10558)

(cherry picked from commit 33d4aa9)

Co-authored-by: Alessio Fabiani <alessio.fabiani@geosolutionsgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 4.1.x cla-signed CLA Bot: community license agreement signed dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants