Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve rules creation using GeoFence batch - WPS #10929

Merged
merged 11 commits into from
May 5, 2023

Conversation

etj
Copy link
Contributor

@etj etj commented Apr 17, 2023

Some more improvements related to #10537, adding WPS specific rules.

The WPS rules have only been implemented since geoserver 2.23.0, so there's a version check to create the proper set of rules.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Apr 17, 2023
@etj etj self-assigned this Apr 17, 2023
Copy link
Contributor

@giohappy giohappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@etj I'd prefer to decide whether use WPS subfields by inspecting the version directly from Geoserver: /geoserver/rest/about/version.json

@etj etj marked this pull request as ready for review April 18, 2023 08:36
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #10929 (fcbefed) into master (5ed2278) will decrease coverage by 0.01%.
The diff coverage is 84.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10929      +/-   ##
==========================================
- Coverage   62.42%   62.41%   -0.01%     
==========================================
  Files         828      828              
  Lines       51526    51547      +21     
  Branches     6593     6598       +5     
==========================================
+ Hits        32165    32175      +10     
- Misses      17658    17664       +6     
- Partials     1703     1708       +5     

@etj etj requested a review from giohappy April 18, 2023 12:26
@giohappy giohappy self-requested a review May 5, 2023 11:12
@giohappy giohappy added this to the 4.1.0 milestone May 5, 2023
@giohappy giohappy merged commit cde29ec into GeoNode:master May 5, 2023
ridoo pushed a commit to Thuenen-GeoNode-Development/geonode that referenced this pull request Jun 2, 2023
* Add WPS subfield rule in GeoFence

* Add WPS subfield rule in GeoFence

* Add WPS subfield rule in GeoFence

* Add WPS subfield rule in GeoFence

* Add WPS subfield rule in GeoFence

* Add WPS subfield rule in GeoFence

* Add WPS subfield rule in GeoFence

* Add WPS subfield rule in GeoFence -- fix parsing geoserver version

---------

Co-authored-by: Giovanni Allegri <giohappy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants