Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #11497] Dehydrate organization field #11498

Merged
merged 4 commits into from
Sep 25, 2023

Conversation

fvicent
Copy link
Contributor

@fvicent fvicent commented Sep 15, 2023

Fixes #11497

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Sep 15, 2023
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #11498 (7e4fbfb) into master (ae6a48a) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11498      +/-   ##
==========================================
+ Coverage   62.04%   62.06%   +0.01%     
==========================================
  Files         867      867              
  Lines       51724    51724              
  Branches     6469     6469              
==========================================
+ Hits        32093    32103      +10     
+ Misses      18091    18080      -11     
- Partials     1540     1541       +1     

@afabiani afabiani added this to the 4.2.0 milestone Sep 19, 2023
@giohappy
Copy link
Contributor

@fvicent keep in mind that the plan is to deprecate api v1 soon and migrate the remaining front end to use api v2. The idea is to implement an adapter on top of api v2 for those parts of the FE that cannot be migrated yet (legacy metadata editor).

@afabiani afabiani merged commit a9afe17 into GeoNode:master Sep 25, 2023
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to see other people's organization
3 participants