Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #12106] Switch to PyLibMCCache #12132

Merged
merged 1 commit into from
Apr 4, 2024
Merged

[Fixes #12106] Switch to PyLibMCCache #12132

merged 1 commit into from
Apr 4, 2024

Conversation

giohappy
Copy link
Contributor

@giohappy giohappy commented Apr 4, 2024

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@giohappy giohappy requested a review from etj April 4, 2024 09:53
@giohappy giohappy self-assigned this Apr 4, 2024
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Apr 4, 2024
Copy link

gitguardian bot commented Apr 4, 2024

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
59204 Triggered Django Secret Key e4b5137 .env_dev View secret
59204 Triggered Django Secret Key e4b5137 .env_local View secret
59204 Triggered Django Secret Key e4b5137 .devcontainer/.env View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@giohappy giohappy linked an issue Apr 4, 2024 that may be closed by this pull request
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Merging #12132 (e4b5137) into master (310d9ef) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12132   +/-   ##
=======================================
  Coverage   64.06%   64.06%           
=======================================
  Files         870      870           
  Lines       52136    52136           
  Branches     6476     6476           
=======================================
  Hits        33403    33403           
  Misses      17235    17235           
  Partials     1498     1498           

@giohappy giohappy merged commit b295c22 into master Apr 4, 2024
18 checks passed
@giohappy giohappy deleted the issue_12106 branch April 4, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MemcachedCache is not working as django MEMCACHED_BACKEND
2 participants