Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNIP 97: New metadata editor #12794

Draft
wants to merge 96 commits into
base: master
Choose a base branch
from
Draft

GNIP 97: New metadata editor #12794

wants to merge 96 commits into from

Conversation

etj
Copy link
Contributor

@etj etj commented Dec 19, 2024

Complete rewriting of the metadata editor according to GNIP 97

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

Gpetrak and others added 30 commits October 11, 2024 18:00
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Dec 19, 2024
@gannebamm
Copy link
Contributor

Can you please add some very short instructions on how to test it? Either here or (better?) at the GNIP?

@giohappy
Copy link
Contributor

@gannebamm today the GNIP will be updated. There's so much to write! We hope it will be ready by the end of the day, otherwise we will complete it in January, after holidays.

@etj etj mentioned this pull request Dec 20, 2024
5 tasks
@etj
Copy link
Contributor Author

etj commented Dec 20, 2024

@gannebamm I added some info on the internals at #11511

Since we didn't merge the client part yet, you should install it by hand

pip install git+https://github.com/GeoNode/geonode-mapstore-client.git@metadata_manager_build#egg=django_geonode_mapstore_client

We didnt want to set this branch in the requirementsin the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants