Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #6684] GNIP-78: GeoNode generic "Apps" model to include pluggable entities into the framework #6713

Merged
merged 311 commits into from
Dec 10, 2020

Conversation

afabiani
Copy link
Member

Closes #6684

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

afabiani and others added 30 commits October 12, 2020 09:29
(cherry picked from commit e532813)

# Conflicts:
#	geonode/static/lib/css/assets.min.css
#	geonode/static/lib/css/bootstrap-select.css
#	geonode/static/lib/css/bootstrap-table.css
#	geonode/static/lib/js/assets.min.js
#	geonode/static/lib/js/bootstrap-select.js
#	geonode/static/lib/js/bootstrap-table.js
#	geonode/static/lib/js/leaflet-plugins.min.js
#	geonode/static/lib/js/leaflet.js
#	geonode/static/lib/js/moment-timezone-with-data.js
#	geonode/static/lib/js/underscore.js
…_api_v2_proof_of_concept

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@afabiani afabiani self-assigned this Dec 10, 2020
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Dec 10, 2020
@lgtm-com
Copy link

lgtm-com bot commented Dec 10, 2020

This pull request introduces 3 alerts when merging 3f9e7dc into 6527b05 - view on LGTM.com

new alerts:

  • 2 for Unused local variable
  • 1 for Unused import

giohappy
giohappy previously approved these changes Dec 10, 2020
@afabiani afabiani merged commit f554424 into master Dec 10, 2020
@afabiani afabiani deleted the rest_api_v2_geonode_apps branch December 10, 2020 16:00
@lgtm-com
Copy link

lgtm-com bot commented Dec 10, 2020

This pull request introduces 3 alerts when merging e10f843 into 6527b05 - view on LGTM.com

new alerts:

  • 2 for Unused local variable
  • 1 for Unused import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GNIP-78: GeoNode generic "Apps" model to include pluggable entities into the framework
5 participants