Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #7391] MapLegend shows wrong legend instead od the selected (default) style #7394

Merged
merged 2 commits into from
Apr 27, 2021

Conversation

marthamareal
Copy link
Contributor

@marthamareal marthamareal commented Apr 27, 2021

References: #7391

Consider a layer's default_style_name if the layer has a default style set.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Apr 27, 2021
@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #7394 (c44db0f) into master (5f45545) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head c44db0f differs from pull request most recent head e245837. Consider uploading reports for the commit e245837 to get more accurate results

@@           Coverage Diff           @@
##           master    #7394   +/-   ##
=======================================
  Coverage   60.12%   60.13%           
=======================================
  Files         576      576           
  Lines       41343    41345    +2     
  Branches     5433     5434    +1     
=======================================
+ Hits        24859    24861    +2     
- Misses      14991    14995    +4     
+ Partials     1493     1489    -4     

@afabiani afabiani added this to the 3.2 milestone Apr 27, 2021
@afabiani afabiani added the backport 3.2.x PR should be backported to target version label Apr 27, 2021
@afabiani afabiani merged commit 5c5f068 into GeoNode:master Apr 27, 2021
afabiani pushed a commit that referenced this pull request Apr 27, 2021
Co-authored-by: Giovanni Allegri <giohappy@gmail.com>
(cherry picked from commit 5c5f068)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 3.2.x PR should be backported to target version cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants