Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #7390] Fix parsing of style title from UserStyle.Title element #7405

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

afabiani
Copy link
Member

References: #7390

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@afabiani afabiani added the backport 3.2.x PR should be backported to target version label Apr 27, 2021
@afabiani afabiani added this to the 3.2 milestone Apr 27, 2021
@afabiani afabiani self-assigned this Apr 27, 2021
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Apr 27, 2021
@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #7405 (46f95d9) into master (9cb9991) will decrease coverage by 0.01%.
The diff coverage is 3.22%.

@@            Coverage Diff             @@
##           master    #7405      +/-   ##
==========================================
- Coverage   60.11%   60.10%   -0.02%     
==========================================
  Files         576      576              
  Lines       41348    41358      +10     
  Branches     5435     5436       +1     
==========================================
  Hits        24857    24857              
- Misses      14998    15008      +10     
  Partials     1493     1493              

@afabiani afabiani merged commit a4121c9 into master Apr 28, 2021
@afabiani afabiani deleted the ISSUE_7390 branch April 28, 2021 07:46
afabiani pushed a commit that referenced this pull request Apr 28, 2021
…#7405) (#7408)

Co-authored-by: Alessio Fabiani <alessio.fabiani@geo-solutions.it>
marthamareal pushed a commit to geosolutions-it/geonode that referenced this pull request May 18, 2021
…element (GeoNode#7405) (GeoNode#7408)

Co-authored-by: Alessio Fabiani <alessio.fabiani@geo-solutions.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 3.2.x PR should be backported to target version cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant