Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT][Fixes #9799] Thesaurus selectbox performance in metadata editor is v… #9836

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

mattiagiupponi
Copy link
Contributor

…ery slow (#9800)

Co-authored-by: mattiagiupponi 51856725+mattiagiupponi@users.noreply.github.com

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

…ery slow (#9800)

* [Fixes #9799] Thesaurus selectbox performance in metadata editor is very slow

Co-authored-by: mattiagiupponi <51856725+mattiagiupponi@users.noreply.github.com>
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Aug 9, 2022
@mattiagiupponi mattiagiupponi changed the title [Fixes #9799] Thesaurus selectbox performance in metadata editor is v… [BACKPORT][Fixes #9799] Thesaurus selectbox performance in metadata editor is v… Aug 9, 2022
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #9836 (44d5457) into 4.x (7244bdc) will increase coverage by 0.01%.
The diff coverage is 72.91%.

@@            Coverage Diff             @@
##              4.x    #9836      +/-   ##
==========================================
+ Coverage   61.34%   61.36%   +0.01%     
==========================================
  Files         821      821              
  Lines       50285    50306      +21     
  Branches     7747     7744       -3     
==========================================
+ Hits        30848    30870      +22     
+ Misses      17753    17752       -1     
  Partials     1684     1684              

@mattiagiupponi mattiagiupponi merged commit ef89866 into 4.x Aug 9, 2022
@mattiagiupponi mattiagiupponi deleted the bp_ISSUE_9799 branch August 9, 2022 10:29
@afabiani afabiani added this to the 4.0.1 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants