Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #9842] Extra metadata endpoint return 403 even if the user has… #9843

Merged
merged 4 commits into from
Aug 10, 2022

Conversation

mattiagiupponi
Copy link
Contributor

@mattiagiupponi mattiagiupponi commented Aug 10, 2022

… view perms

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Aug 10, 2022
@mattiagiupponi mattiagiupponi self-assigned this Aug 10, 2022
@mattiagiupponi mattiagiupponi added this to the 4.0.1 milestone Aug 10, 2022
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #9843 (b62f1d1) into master (baa3268) will decrease coverage by 0.00%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##           master    #9843      +/-   ##
==========================================
- Coverage   61.34%   61.34%   -0.01%     
==========================================
  Files         822      822              
  Lines       50298    50298              
  Branches     7745     7745              
==========================================
- Hits        30856    30855       -1     
- Misses      17763    17764       +1     
  Partials     1679     1679              

geonode/base/api/views.py Outdated Show resolved Hide resolved
@marthamareal
Copy link
Contributor

I get the following error trying to add user with view permission using UI

 File "/opt/geonode/geonode/base/api/views.py", line 583, in resource_service_permissions
    perms_spec_compact = PermSpecCompact(request.data, resource)
  File "/opt/geonode/geonode/security/permissions.py", line 370, in __init__
    self._bind_json(json)
  File "/opt/geonode/geonode/security/permissions.py", line 378, in _bind_json
    val = json.pop(binding.name, None)
  File "/home/marthamareal/.virtualenvs/geonode/lib/python3.8/site-packages/django/http/request.py", line 552, in pop
    self._assert_mutable()
  File "/home/marthamareal/.virtualenvs/geonode/lib/python3.8/site-packages/django/http/request.py", line 510, in _assert_mutable
    raise AttributeError("This QueryDict instance is immutable")
AttributeError: This QueryDict instance is immutable

@mattiagiupponi
Copy link
Contributor Author

I get the following error trying to add user with view permission using UI

@marthamareal can you please try on another resource?
I'm trying it on my local env and is working as expected

@marthamareal
Copy link
Contributor

I had not updated my client version. After updating, tests work as expected

@mattiagiupponi mattiagiupponi merged commit fa5421b into master Aug 10, 2022
@mattiagiupponi mattiagiupponi deleted the ISSUE_9842 branch August 10, 2022 15:58
github-actions bot pushed a commit that referenced this pull request Aug 10, 2022
#9843)

* [Fixes #9842] Extra metadata endpoint return 403 even if the user has view perms
mattiagiupponi added a commit that referenced this pull request Aug 10, 2022
#9843) (#9844)

* [Fixes #9842] Extra metadata endpoint return 403 even if the user has view perms

Co-authored-by: mattiagiupponi <51856725+mattiagiupponi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants