Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up services #227

Closed
wants to merge 2 commits into from
Closed

Conversation

sdpeyton
Copy link
Collaborator

@sdpeyton sdpeyton commented Jan 5, 2019

What

This PR simplifies our 3 services. Instead of exporting objects with methods, this PR adjusts the services so that they export simple functions.

Update The PR was closed because it had gone stale after a bad build. I rebased and re-built the docs/ directory and tested to make sure it now works.

Here's the previous PR: #218

@DanielJDufour
Copy link
Member

@sdpeyton , there's some merge conflicts

@DanielJDufour
Copy link
Member

Closing as this has gone stale. Happy to take another look if conflicts resolved and it's updated :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants