-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for TIN geometry type #178
Conversation
Clean up a bit
looks nice! Can you add some real world testdata and a testcase in the pg2b3dm.database.tests project? |
Pushed a simple test, could you have a look? |
something else goes wrong with the tests, I'll take a look |
Seems to be dependency problem. Have the feeling this could be a version conflict between https://www.myget.org/feed/bertt/package/nuget/SharpGLTF.Toolkit/1.0.0 and https://www.nuget.org/packages/SharpGLTF.Toolkit/1.0.0 |
ah yes good suggestion, I thought everything from myget was deleted... strange it does work well on https://github.com/geodan/pg2b3dm |
fixed the test, I've deleted the package on https://www.myget.org/feed/bertt/package/nuget/SharpGLTF.Toolkit/1.0.0 |
@@ -19,6 +19,7 @@ | |||
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets> | |||
</PackageReference> | |||
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.10.0" /> | |||
<PackageReference Include="SharpGLTF.Toolkit" Version="1.0.0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not needed, reference to SharpGltf is defined in project wkb2gltf.core
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed it
@@ -18,6 +18,7 @@ | |||
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets> | |||
</PackageReference> | |||
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.10.0" /> | |||
<PackageReference Include="SharpGLTF.Toolkit" Version="1.0.0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
src/b3dm.tileset/b3dm.tileset.csproj
Outdated
@@ -8,6 +8,7 @@ | |||
|
|||
<ItemGroup> | |||
<PackageReference Include="Npgsql" Version="8.0.3" /> | |||
<PackageReference Include="SharpGLTF.Toolkit" Version="1.0.0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@@ -19,6 +19,7 @@ | |||
<PrivateAssets>all</PrivateAssets> | |||
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets> | |||
</PackageReference> | |||
<PackageReference Include="SharpGLTF.Toolkit" Version="1.0.0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Tested with Delaware buildings, looks alright Steps: Download shapefile: https://1drv.ms/u/s!AqWv0F0N63JkgQqO6E9e2kI28R16 $ ogr2ogr -f "PostgreSQL" PG:"host=localhost user=postgres password=postgres dbname=postgres" bldg_footprints.shp -nlt POLYGON -nln delaware_buildings postgresql> ALTER TABLE delaware_buildings ADD COLUMN geom1 geometry; postgresql> UPDATE delaware_buildings set geom1 = ST_force3d(st_tesselate(wkb_geometry)) $ pg2b3dm -U postgres -d postgres -h localhost -p 5432 -t delaware_buildings -c geom1 |
Thanks, nice addition! Will be in next release. |
... and cleaned up a bit
Note I am kind of new to this, so please be extra careful :)