Throw an error if an import or export statement isn’t at the top-leve…

…l scope, with tests
GeoffreyBooth · Aug 19, 2016 · 3eb4533 · lydell · Aug 19, 2016 · GeoffreyBooth
1 parent be49dc0
commit 3eb4533
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/src/nodes.coffee b/src/nodes.coffee
@@ -1243,6 +1243,9 @@ exports.Module = class Module extends Base
   makeReturn:  THIS
 
   compileNode: (o) ->
+    if o.indent.length isnt 0
+      @error "#{@type} statements must be at top-level scope"
+
     code = []
 
     code.push @makeCode "#{@tab}#{@type} "

diff --git a/test/error_messages.coffee b/test/error_messages.coffee
@@ -1008,3 +1008,22 @@ test "anonymous classes cannot be exported", ->
       @constructor: ->
         console.log 'hello, world!'
   ''', 'SyntaxError: anonymous classes cannot be exported'
+
+test "imports and exports must be top-level", ->
+  assertErrorFormat '''
+    if foo
+      import { bar } from 'lib'
+  ''', '''
+    [stdin]:2:3: error: import statements must be at top-level scope
+      import { bar } from 'lib'
+      ^^^^^^^^^^^^^^^^^^^^^^^^^
+  '''
+
+  assertErrorFormat '''
+    foo = ->
+      export { bar }
+  ''', '''
+    [stdin]:2:3: error: export statements must be at top-level scope
+      export { bar }
+      ^^^^^^^^^^^^^^
+  '''