Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folium map #1145

Merged
merged 4 commits into from
Sep 27, 2023
Merged

Folium map #1145

merged 4 commits into from
Sep 27, 2023

Conversation

uchchwhash
Copy link
Member

@uchchwhash uchchwhash commented Sep 23, 2023

Proposed changes

  • Provide helper functions folium_map and ipyleaflet_map that enables easy placing of an xarray Dataset on a webmap
  • Provide folium_dual_map that lets us compare datasets side-by-side
  • These functions support styling using the datacube OWS configuration

Closes issues (optional)

Checklist (replace [ ] with [x] to check off)

  • Notebook created using the DEA-notebooks template
  • Remove any unused Python packages from Load packages
  • Remove any unused/empty code cells
  • Remove any guidance cells (e.g. General advice)
  • Ensure that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended).
  • Include relevant tags in the final notebook cell (refer to the DEA Tags Index, and re-use tags if possible)
  • Clear all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated
  • Test notebook on both the NCI and DEA Sandbox (flag if not working as part of PR and ask for help to solve if needed)
  • If applicable, update the Notebook currently compatible with the NCI|DEA Sandbox environment only line below the notebook title to reflect the environments the notebook is compatible with

Have not testing on NCI.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@review-notebook-app
Copy link

review-notebook-app bot commented Sep 27, 2023

View / edit / reply to this conversation on ReviewNB

geoscience-aman commented on 2023-09-27T06:15:58Z
----------------------------------------------------------------

"Last modified: September 2023"?


Copy link
Collaborator

@geoscience-aman geoscience-aman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The locking feature across two layers side-by-side looks great!

@uchchwhash uchchwhash merged commit a05300f into develop Sep 27, 2023
2 checks passed
@uchchwhash uchchwhash deleted the folium-map branch September 27, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants