Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit tide data downloaded in tests #1177

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Limit tide data downloaded in tests #1177

merged 1 commit into from
Jan 29, 2024

Conversation

robbibt
Copy link
Member

@robbibt robbibt commented Jan 28, 2024

Proposed changes

As part of the DEA Intertidal project, we recently we updated the tide model data available on the S3 dea-non-public-data bucket to include data from an additional ~5 tide models.

To avoid this new data being synced during the DEA Notebooks integration tests (potentially leading to longer run times), this PR updates the "Copy tide modelling files with the AWS CLI" step of our tests to only download a smaller subset of the tide model data.

Copy link
Collaborator

@CEKrause CEKrause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@robbibt robbibt merged commit 05f1e55 into develop Jan 29, 2024
1 check passed
@robbibt robbibt deleted the tide_data branch January 29, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants