-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user-friendly landing page to DEA Sandbox #1187
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest <img src="Supplementary_data/dea_logo_wide.jpg" width="2000"/>
maybe so it covers the whole width of a larger monitor screen without affecting the display on a smaller laptop screen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When referring to DEA Tools, maybe we can link to the PyPI package?
https://pypi.org/project/dea-tools/0.3.0/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @geoscience-aman , I think it would be better if the header image was wider but I tried applying a larger width and it stretches the image beyond its natural limit and makes it blurry unfortunately. Unless we have a larger version of dea_logo_wide.jpg somewhere @robbibt ?
Also, it will be great if we link to the Pypy package however I think it would be better for the user experience if we put it on the DEA Tools cover page: https://docs.dea.ga.gov.au/notebooks/Tools/
I will create a PR to suggest adding it to that page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree 💯 about the banner, but as far as I know it's the widest version we have... although I can't remember where it originally came from or if it was something custom we put together for DEA Notebooks.
Might need to be a future improvement for this one I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm so excited about this :) Looks good
Proposed changes
This PR provides a user friendly landing page that will make it easier for users to learn about the content available in the Sandbox, and useful reference information in the Knowledge Hub:
Closes issues (optional)
Checklist
(Replace
[ ]
with[x]
to check off)Load packages
General advice
)jupyterlab_code_formatter
tool can be used to format code cells to a consistent style: select each code cell, then clickEdit
and then one of theApply X Formatter
options (YAPF
orBlack
are recommended).NCI
andDEA Sandbox
(flag if not working as part of PR and ask for help to solve if needed)Notebook currently compatible with the NCI|DEA Sandbox environment only
line below the notebook title to reflect the environments the notebook is compatible with