Temporarily modify spatial.py
tests to work around odc-geo
Geobox comparison precision issue
#1235
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
A recent change in
odc-geo
(link here) is causing our tests to fail againstodc-geo
version 0.4.7, due to tiny differences in coordinate certainty causing comparisons like this to fail:This PR implements a temporary workaround using a new
geobox_test
testing function that compares GeoBoxes usingnp.allclose
to account for tiny differences in coordinate precision. This should be reverted if anodc-geo
fix/workaround becomes available.