Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WIT to add note about loading polygons without elevation values #1250

Merged
merged 2 commits into from
Jul 28, 2024

Conversation

LaurenSchenk1
Copy link
Collaborator

Proposed changes

Include a note in WIT notebook when loading polygons to remove any Z/elevation values

Checklist

(Replace [ ] with [x] to check off)

  • Notebook created using the DEA-notebooks template
  • Remove any unused Python packages from Load packages
  • Remove any unused/empty code cells
  • Remove any guidance cells (e.g. General advice)
  • Ensure that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended).
  • [] Include relevant tags in the final notebook cell (refer to the DEA Tags Index, and re-use tags if possible)
  • Clear all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated
  • Test notebook on both the NCI and DEA Sandbox (flag if not working as part of PR and ask for help to solve if needed)
  • If applicable, update the Notebook currently compatible with the NCI|DEA Sandbox environment only line below the notebook title to reflect the environments the notebook is compatible with
  • Check for any spelling mistakes using the DEA Sandbox's built-in spellchecker (double click on markdown cells then right-click on pink highlighted words). For example:

sandbox_spellchecker

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@robbibt
Copy link
Member

robbibt commented Jul 25, 2024

Hey @LaurenSchenk1, no issues with this and happy to approve, but out of curiousity, do we know what's going wrong here? Seems like a weird one (would have expected WIT to be just using the geometry of the polygons, not any of their fields). Perhaps something that we might want to think about fixing in the WIT code itself (or at least raising some kind of warning/error so it doesn't fail silently)

Copy link
Member

@robbibt robbibt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Feel free to "squash and merge" once the tests run 🙂

@LaurenSchenk1 LaurenSchenk1 merged commit 51a3cdb into develop Jul 28, 2024
1 check passed
@LaurenSchenk1 LaurenSchenk1 deleted the Lauren-WIT_update branch July 28, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants