Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate tide modelling tools in favour of eo-tides #1276

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Deprecate tide modelling tools in favour of eo-tides #1276

merged 1 commit into from
Nov 14, 2024

Conversation

robbibt
Copy link
Member

@robbibt robbibt commented Nov 14, 2024

Proposed changes

We are in the process of moving our tide modelling tools to a smaller, easier to install Python package called eo-tides:
https://geoscienceaustralia.github.io/eo-tides/

This PR adds a deprecation warning to all affected tide modelling functions in dea-tools, in preperation for eventually removing them from this repo. The warning points to the following migration guide which should help users update their code:
https://geoscienceaustralia.github.io/eo-tides/migration/

Closes issues (optional)

erialC-P
erialC-P approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@erialC-P erialC-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super organised! This will really help users migrate over to the new package. Nice work :)

@erialC-P erialC-P merged commit 0204f80 into develop Nov 14, 2024
1 check passed
@erialC-P erialC-P deleted the deprecate_tides branch November 14, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erialC-P erialC-P erialC-P approved these changes

@BexDunn BexDunn Awaiting requested review from BexDunn BexDunn is a code owner

@uchchwhash uchchwhash Awaiting requested review from uchchwhash uchchwhash is a code owner

@Kooie-cate Kooie-cate Awaiting requested review from Kooie-cate Kooie-cate is a code owner

@geoscience-aman geoscience-aman Awaiting requested review from geoscience-aman geoscience-aman is a code owner

@JM-GA JM-GA Awaiting requested review from JM-GA JM-GA is a code owner

@margaretharrison margaretharrison Awaiting requested review from margaretharrison margaretharrison is a code owner

@vnewey vnewey Awaiting requested review from vnewey vnewey is a code owner

@Ariana-B Ariana-B Awaiting requested review from Ariana-B Ariana-B is a code owner

@amanda2099 amanda2099 Awaiting requested review from amanda2099 amanda2099 is a code owner

@supermarkion supermarkion Awaiting requested review from supermarkion supermarkion is a code owner

@erin-telfer erin-telfer Awaiting requested review from erin-telfer erin-telfer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robbibt @erialC-P