Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage null value for some fields #1170

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

dtrucs
Copy link
Collaborator

@dtrucs dtrucs commented Jun 12, 2024

The following fields are defined as "string" type in Geotrek-Admin:

  • departure
  • arrival
  • ambiance
  • access
  • description_teaser

But some parsers may set them to null on import.
We therefore manage these fields in case they return null instead of a string.

cc @marcantoinedupre

@dtrucs dtrucs requested a review from a team June 12, 2024 13:48
@dtrucs dtrucs changed the base branch from main to develop June 12, 2024 13:48
@dtrucs dtrucs force-pushed the Manage-null-value-for-some-fields branch from fa8c17d to 5cfc2f8 Compare June 12, 2024 13:52
@marcantoinedupre
Copy link

Thanks @dtrucs! I have created an issue on geotrek-admin: GeotrekCE/Geotrek-admin#4192. So hopefully we will be able to fix the root cause.

@dtrucs dtrucs merged commit b91abf8 into develop Jun 20, 2024
2 checks passed
@dtrucs dtrucs deleted the Manage-null-value-for-some-fields branch June 20, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants