Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define go back button on details pages #1303

Merged
merged 6 commits into from
Nov 19, 2024

Conversation

dtrucs
Copy link
Collaborator

@dtrucs dtrucs commented Nov 14, 2024

ref #1282

@dtrucs dtrucs requested a review from a team November 14, 2024 09:03
Copy link
Member

@babastienne babastienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some information in the documentation to explain how to hide the button ? You did it in the dedicated issue but imo it should also be documented in the official documentation.

@dtrucs
Copy link
Collaborator Author

dtrucs commented Nov 19, 2024

@babastienne

Can you add some information in the documentation to explain how to hide the button ? You did it in the dedicated issue but imo it should also be documented in the official documentation.

The documentation already talks about style overrides (https://github.com/GeotrekCE/Geotrek-rando-v3/blob/main/docs/customization/customization-themestyles.md#css):

In addition, some classes prefixed with custo-* are gradually being added to facilitate style overrides for components.

I'm not sure it's relevant to document how to display or not this element with CSS in the App. In that case, where's the limit? Because everything could be hidden...

@camillemonchicourt
Copy link
Member

@babastienne

Can you add some information in the documentation to explain how to hide the button ? You did it in the dedicated issue but imo it should also be documented in the official documentation.

The documentation already talks about style overrides (https://github.com/GeotrekCE/Geotrek-rando-v3/blob/main/docs/customization/customization-themestyles.md#css):

In addition, some classes prefixed with custo-* are gradually being added to facilitate style overrides for components.

I'm not sure it's relevant to document how to display or not this element with CSS in the App. In that case, where's the limit? Because everything could be hidden...

Yes, I agree with that. I would not add it in the global customization, but good to have it in the dedicated issue as actually.

@babastienne
Copy link
Member

Ok I agree too, let's do that.

@dtrucs dtrucs merged commit 309458f into develop Nov 19, 2024
2 checks passed
@dtrucs dtrucs deleted the Define-go-back-button-on-details-pages branch November 19, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants